facebookresearch / facebookresearch/fairo

Message shows up as green checkmark even if server didn't receive message

Open
#604 0 comments 0 reactions 1 assignee Claimed by @kavyasrinet View on GitHub
dashboard
Dominant language
Jupyter Notebook
Stars
929
Forks
123
PR merge metrics
No merged PRs in 30d

Description

## Type of Issue

Select the type of issue:
- [x] Bug report (to report a bug)
- [ ] Feature request (to request an additional feature)
- [ ] Tracker (I am just using this as a tracker)
- [ ] Refactor request
- [ ] Documentation Ask

## Description
Message shows up with green emoji even if the backend server isn't correct. When user types in message to the robot, the first time it happens there is a red cross. However, once the red cross turns green and the user sends in another message, the message immediately shows up as green suggesting that the message has been received by the backend when in reality that is not the case (since it is too fast). Message should default to red, then only turn green once the server resends the socket call.

![image](https://user-images.githubusercontent.com/40724569/127071382-8cb1747f-dfe3-4b6f-871d-125db57676e1.png)
## Steps to reproduce

Please add steps to reproduce the bug here along with the stack trace.
Start locobot server.
Access web dashboard
Connect to the server (wait for green light)
Send message to robot (there will be a red cross next to the message)
![image](https://user-images.githubusercontent.com/40724569/127071649-0b00dd8b-c30a-4284-9066-3a4736d8c726.png)

Wait for message to turn green
![image](https://user-images.githubusercontent.com/40724569/127071680-86d8ea93-5d75-42da-a0dc-90ae7b4be82a.png)

Switch backend to incorrect host and send message. Observe how default is green checkmark
![image](https://user-images.githubusercontent.com/40724569/127071731-22481627-a332-4201-98c5-4c8d6dcd94ad.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.