facebookresearch / facebookresearch/fairo

transform_pose redundant across multiple files

Open
#435 0 comments 0 reactions 2 assignees Claimed by @anuragprat1k View on GitHub
Dominant language
Jupyter Notebook
Stars
929
Forks
123
PR merge metrics
No merged PRs in 30d

Description

## Type of Issue

Select the type of issue:
- [ ] Bug report (to report a bug)
- [ ] Feature request (to request an additional feature)
- [ ] Tracker (I am just using this as a tracker)
- [ ] Refactor request
- [ ] Documentation Ask

## Description

Right now the files : `remote_locobot.py`, `locobot_mover_utils.py` and `depth_util.py` all have the same definition and implementation for a method called `transform_pose` . Is it okay to just keep this in for example : `depth_util.py` or do we need it in different contexts in the three places ?

I can move it, just want to make sure I am not breaking any use cases.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.