facebookresearch / facebookresearch/fairo

[Validator] Validate ground truth logical forms used in parsing test

Open
#346 0 comments 0 reactions 1 assignee Claimed by @Rebecca-Qian View on GitHub
hack-session-worthy P2 testing
Dominant language
Jupyter Notebook
Stars
929
Forks
123
PR merge metrics
No merged PRs in 30d

Description

## Type of Issue

Select the type of issue:
- [ ] Bug report (to report a bug)
- [x] Feature request (to request an additional feature)
- [ ] Tracker (I am just using this as a tracker)
- [ ] Refactor request
- [ ] Documentation Ask

## Description

The logical forms used in the parsing test should be in sync with ground truth, and the grammar. They should be added to the data validation unit test.

## Current Behavior

Validator unit tests cover the data files, but not the logical forms used in `common_functional_commands`.

## Expected Behavior

Add a new unit test to grammar validation tests.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.