facebookresearch / facebookresearch/fairo

Add flag in agent to catch all exceptions

Open
#342 11 comments 0 reactions 0 assignees View on GitHub
feature request hack-session-worthy help wanted P0
Dominant language
Jupyter Notebook
Stars
929
Forks
123
PR merge metrics
No merged PRs in 30d

Description

## Type of Issue

Select the type of issue:
- [x] Bug report (to report a bug)
- [ ] Feature request (to request an additional feature)
- [ ] Tracker (I am just using this as a tracker)
- [ ] Refactor request
- [ ] Documentation Ask

## Description
Support a mode where the agent fails gracefully.

## Current Behavior

Exceptions are always raised, which is bad UX for non internal users. This is especially problematic when we're running agent in remote containers, where we can't intervene to restart after crashes.

## Expected Behavior

In production settings, let's catch all exceptions instead of raising.

Code pointers:
https://github.com/facebookresearch/droidlet/blob/main/base_agent/core.py#L16
https://github.com/facebookresearch/droidlet/blob/77e9ad05dd68249a7c0fdba13c8b4f853ff5ec5f/base_agent/loco_mc_agent.py#L147
https://github.com/facebookresearch/droidlet/blob/main/base_agent/loco_mc_agent.py#L208

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.