facebookresearch / facebookresearch/fairo

[Polymetis] Server breaks without informative errors

Open
#1,324 0 comments 0 reactions 1 assignee Claimed by @exhaustin View on GitHub
Dominant language
Jupyter Notebook
Stars
929
Forks
123
PR merge metrics
No merged PRs in 30d

Description

## Type of Issue

Select the type of issue:
- [ ] Bug report (to report a bug)
- [x] Feature request (to request an additional feature)
- [ ] Tracker (I am just using this as a tracker)
- [ ] Refactor request
- [ ] Documentation Ask

## Description

## Current Behavior

When `polymetis_pb2.RobotState` does not have valid lengths for the repeated fields, the server fails to execute the request and continues to run while returning the following uninformative status:
```
StatusCode.UNAVAILABLE
details = "Socket closed"
debug_error_string = "{"created":"@1659472214.520993418","description":"Error received from peer ipv6:[::1]:50051","file":"src/core/lib/surface/call.cc","file_line":952,"grpc_message":"Socket closed","grpc_status":14}"
```

## Expected Behavior

Informative error messages on the Polymetis server side to inform the user of what the problem is and even pinpoint the exact RobotState field that's causing the problem.

## Steps to reproduce

Please add steps to reproduce the bug here along with the stack trace.

## Links to any relevant pastes or documents

Please post links to any relevant documents that might contain any extra information.

## Checklist

Use this checklist if you are using this issue as a tracker:

- [ ] Task 1
- [ ] Task 2
- [ ] Task 3 ...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.