facebookresearch / facebookresearch/blt

Mistake in FLOPs calculations in the paper

Open
#61 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
2.1k
Forks
196
PR merge metrics
No merged PRs in 30d

Description

Local models forwards at each byte, but debedder in BPE forwards at each token which is 4.4 times smaller in FLOPS. Considering your architecture hyper-parameters it seems like you missed that. In small models it gives advantage in terms of FLOPs for BLT for ±17%.

My calculations with proofs:
1) With your formulas: https://www.desmos.com/calculator/ippsrya4kf?lang=ru
2) With another formulas: https://colab.research.google.com/drive/1C3As0sG-SL482KslP-DxylpAYut-9nyM?usp=sharing #

Contributor guide

Open the contributing guide

Research direction

Compare the paper's FLOPs formulas with the calculations in the linked Desmos and Colab documents, focusing on the local-model byte forwards and BPE token forwards described in the issue. Reproduce the discrepancy using the stated architecture hyperparameters; the work is done when the calculation is verified and the paper or its formulas are corrected or the concern is explained.

Written by the indexing model from the issue text.

Assessment

Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.