facebookresearch / facebookresearch/aepsych

Refactor AEPsych models to not require dim instead of lb, ub in constructor

Open
#379 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
75
Forks
58
PR merge metrics
No merged PRs in 30d

Description

AEPsych models currently require lower bounds and upper bounds of parameters to be passed into their constructors, but the model itself should not have to worry about the bounds of the space; that's the responsibility of the strategy. All the model really needs to know is the dimensionality of the space. Removing the lb and ub from the constructor would reduce a lot of boilerplate. Wherever a model method requires self.lb or self.ub, we should be able to refactor it so that the method takes those as parameters that can be passed in by the strategy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.