facebookresearch / facebookresearch/aepsych

Remove `#type: ignore ` comments from codebase

Open
#367 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
75
Forks
58
PR merge metrics
No merged PRs in 30d

Description

There are a few instances in the code where mypy is unhappy and we have added `#type: ignore` comments to bypass the issue rather than fix the underlying error. We should remove these and implement proper type hinting where possible. There may be instances where trying to accommodate mypy is impossible or more cumbersome than just leaving in the `#type: ignore` comments, but in these instances we should add comments explaining why.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.