facebookresearch / facebookresearch/SpinQuant

activation quantization of v_proj and o_proj

Open
#30 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
428
Forks
93
PR merge metrics
No merged PRs in 30d

Description

Thanks for sharing the code for such nice work!

I have one question about the activation quantization configuration.
It seems that the quantization granularity of both the output of `v_proj` and the input of `o_proj` is always set to `head_dim` in `eval_utils/main.py`, which is not consistent with the conventional setting in other quantization works such as QuaRot.

Could you clarify whether the results reported in the paper are from this head-wise quantization setting or the per-token quantization setting as mentioned in the paper?

Thanks.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.