facebookresearch / facebookresearch/SlowFast

multi clip test bug in SSv2

Open
#306 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
7.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Hi,

https://github.com/facebookresearch/SlowFast/blob/fd41618191d3c21c1ca21a61369ce9917646cf9c/slowfast/datasets/ssv2.py#L223-L229

When self.mode == "test",

https://github.com/facebookresearch/SlowFast/blob/fd41618191d3c21c1ca21a61369ce9917646cf9c/slowfast/datasets/ssv2.py#L229

Since this code generates always the same frame_list regardless of num_clips, multi_clips_test shows the same accuracy.

What do you think about this?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.