facebookresearch / facebookresearch/SlowFast

why use the `width_per_group` as the `dim_in`

Open
#233 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
7.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Hi,
Thanks for the open-resource work.

I wonder why use the `width_per_group` as the `dim_in`?
Do you think it is more reasonable to use `width_per_group * num_groups` as `dim_in`, although this two are alway same when `num_groups=1`.

Or do I miss something?

Thanks in advance.

https://github.com/facebookresearch/SlowFast/blob/bda005363ff589405e19b0ed0ba063eb0752ec97/slowfast/models/video_model_builder.py#L463-L465

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.