facebookresearch / facebookresearch/SlowFast

An error in temporal sampling?

Open
#176 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
7.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Thanks for your wonderful code!
But I am confused by an implemental detail that does not match your paper.
https://github.com/facebookresearch/SlowFast/blob/dde28ccbdb3f0f323398124d639ee2538dbd9de2/slowfast/datasets/decoder.py#L25
`torch.linspace(start, end, steps=100, out=None, dtype=None, layout=torch.strided, device=None, requires_grad=False) → Tensor`
means

> Returns a one-dimensional tensor of steps equally spaced points between start and end.

For example,
if the stride is 16, the number of frames is 4, start_idx is 7. So we can get end_idx = 7 + 4 * 16 - 1 = 70. Then we call temporal_sampling() function, the result is as below.
`torch.linspace(7, 70, 4)
tensor([ 7., 28., 49., 70.])
`
It does not satisfy stride 16 but comes to 21!
Is there any mistake when calculating end_idx or something else?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.