facebookresearch / facebookresearch/ReAgent

DO_NOT_PREPROCESS features getting clamped

Open
#205 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
3.7k
Forks
529
PR merge metrics
No merged PRs in 30d

Description

`DO_NOT_PREPROCESS` feature types should probably not get modified in preprocessing. For example, a `DO_NOT_PREPROCESS` feature with values `[12.5, 100.5, 7.2, 8.2]` would become `[6, 6, 6, 6]` due to the clamping.

https://github.com/facebookresearch/ReAgent/blob/b5ee54cd8e4108dfad1b9e69ff0cf299b47a5dc7/ml/rl/preprocessing/preprocessor.py#L152-L163

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.