facebookresearch / facebookresearch/LayerSkip
Recent changes break code
Open
- Dominant language
- Python
- Stars
- 380
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Description
Hi, [this commit change](https://github.com/facebookresearch/LayerSkip/commit/9003536b0d8c06987766478939b13f4b77ce69fe) breaks generation, eval, and likely other scripts because in transformers v4.46, `position_embeddings` is a required field, but it isn't passed in `forward_early` or `forward_remaining`. See https://github.com/huggingface/transformers/blob/53fad641cfdb5105e2470bcf3ef17ea8e25cc300/src/transformers/models/llama/modeling_llama.py#L369
Contributor guide
Assessment
This issue has not been assessed yet.