facebookresearch / facebookresearch/DistDepth
Questions about the loss computation
- Dominant language
- Python
- Stars
- 236
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
Hi, thanks for releasing the code!
I have several questions after reading the *execute_func.py*:
- At [L78](https://github.com/facebookresearch/DistDepth/blob/dda0ffcb19d14ae35e21e093d6160ae50074ac07/execute_func.py#L78), the DPT is initialized with `invert=True`, which means the output is already depth. While at [L253](https://github.com/facebookresearch/DistDepth/blob/dda0ffcb19d14ae35e21e093d6160ae50074ac07/execute_func.py#L253), a division is performed again to convert the output of DPT to depth. Is there a comment error here, since from what I understand, the code at L254 seems to be correct.
- At [L378](https://github.com/facebookresearch/DistDepth/blob/dda0ffcb19d14ae35e21e093d6160ae50074ac07/execute_func.py#L378), the *pseudo_depth* error is computed between `outputs["fromMono_dep"]` and `outputs[('depth', 0, 0)]`, which have different scales. Should `outputs["fromMono_dep"]` be replaced by `target_depth` at L353, since its scale has been aligned.
Looking forward to your reply.
Best regards!
Contributor guide
Assessment
This issue has not been assessed yet.