facebookresearch / facebookresearch/DeepHandMesh

parameter naming in DiffableRenderer.py

Open
#6 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
100
Forks
15
PR merge metrics
No merged PRs in 30d

Description

There is an ambiguity in the parameter naming for this function:

`forward(self, mesh, cam_param, img_affine_trans_mat, mesh)`

The parameter name `mesh` gets repeated twice. Can you please check?

https://github.com/facebookresearch/DeepHandMesh/blob/ea90b752bf758076c64331cb38db497a181f8a06/common/nets/DiffableRenderer/DiffableRenderer.py#L27

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.