facebookexperimental / facebookexperimental/siMMMulator

Budget Minimum Proportions must be > 0

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
64
Forks
14
PR merge metrics
No merged PRs in 30d

Description

The documentation says that the minimum spend proportion for each channel should be between 0 and 1. Whilst technically this is correct, it would be useful to make it clear that (currently) the minimum value must be > 0, else you get the following error:

```
Error in step_2_ads_spend(my_variables = my_variables, campaign_spend_mean = weekly_spend, :
You entered a negative proportion of spend on a channel. Enter a proportion between 0 and 1
```

An alternative option (and better option, in my opinion) would be to allow zero spend to be a valid value.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.