facebookexperimental / facebookexperimental/siMMMulator

Bad default value

Open
#16 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
64
Forks
14
PR merge metrics
No merged PRs in 30d

Description

This default value:

https://github.com/facebookexperimental/siMMMulator/blob/da44d9afdbf3012078deba7a98f4d2999dcccf93/R/step_1_create_baseline.R#L35

(using `my_variables` as the default for `my_variables`) will never work. Either the user specified the argument and the default isn't used, or the user didn't, in which case it will try to use itself as the value, and will fail, as in this SO question: https://stackoverflow.com/q/77511658

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.