facebookexperimental / facebookexperimental/reverie
ptr types implement Displayable instead of Display
- Dominant language
- Rust
- Stars
- 836
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
I'll have to start mentioning that I'm new to rust, so I may have gotten something wrong here.
many Syscall structs have a .path() method that returns a pathptr of the syscall destinantion.
option of pathptr implements the Displayable trait, which according to code comments is intended for full syscalls.
This seems to be a typo, as the signature implemented fits the Display trait more (I.E. only 1/3 of the functions declared in Displayable are implemented), which would also make sense as it would allow for `format!("{call.path()}")`.
from looking at the other types many other ptr types seem to share this. but some functions have both traits in the signature so I don't know what parts should actually be changed to fix this fully myself.
regards.
Contributor guide
Assessment
This issue has not been assessed yet.