facebookexperimental / facebookexperimental/libunifex

Rename is_stop_never_possible to is_stop_ever_possible

Open
#89 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.7k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

The usage of this query quite often ends up needing to be negated which ends up with a double negative (not is stop never possible) instead of the positive form (is stop ever possible).

eg.
```
if constexpr (!is_stop_never_possible_v) {
// handle possibility of stop being requested
}
```

Inverting this and using the positive form would allow this code to read better:
```
if constexpr (is_stop_ever_possible_v) {
// handle possibility of stop being requested.
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.