facebookexperimental / facebookexperimental/libunifex

Compile error with MSVC in default settings

Open
#591 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.7k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

I am using this library for the first time. I'm attempting to integrate it into my project using CMake `FetchContent`. When compiling on Windows, I consistently encounter the `error C2370`. After consulting the CI logs, I found that the error occurs when using C++17, but it compiles successfully with C++20. As a workaround, I changed the C++ version in the code to `cxx_std_20`, and it worked fine.
https://github.com/facebookexperimental/libunifex/blob/e14d5cac13193a37934ea58c9226c693cfc305f8/source/CMakeLists.txt#L79
Could you please address the compilation error when using C++17, or consider setting the default C++ version to C++20 when using MSVC?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.