facebookexperimental / facebookexperimental/libunifex

`let_error()` should use a `try-catch` block in `set_value()`

Open
#452 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
1.7k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

`values` construction may throw. Use `UNIFEX_TRY {} UNIFEX_CATCH {}` to forward `current_exception` to `set_error`.

https://github.com/facebookexperimental/libunifex/blob/99b39667e04f6f12ef1bed9a5c69312cc1a9abd3/include/unifex/let_error.hpp#L92

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.