facebookexperimental / facebookexperimental/Robyn

Cant reopen this issue but it is still an issue and you can see the problem in your code base

Open
#1,264 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
1.5k
Forks
433
PR merge metrics
No merged PRs in 30d

Description

Closing an issue by declaring it fixed is not the same as fixing it.

Line 673 in robyn/modeline/pareto/plog_data_generator.py still has the hard coded value
"y_pred": dt_saturated_dfs.dt_modSaturated["dep_var"].iloc[

The person who opened the last version of the issue likely did not fix it but instead gave up and started using meridian

https://github.com/facebookexperimental/Robyn/issues/1240#issue-2941436677

This is likey the culprit I have a field called revenue_contributions which does not get renamed and fails

```
# Check if 'revenue' exists in the columns
if "revenue" in dt_saturated_dfs.dt_modSaturated.columns:
# Rename 'revenue' to 'dep_var'
dt_saturated_dfs.dt_modSaturated = dt_saturated_dfs.dt_modSaturated.rename(
columns={"revenue": "dep_var"}
)
# print("Column 'revenue' renamed to 'dep_var'.")
else:
# print("Column 'revenue' does not exist.")
pass
decompCollect = self._model_decomp(
inputs={
"coefs": coefs_df,
"y_pred": dt_saturated_dfs.dt_modSaturated["dep_var"].iloc[
rollingWindow
],
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.