facebookexperimental / facebookexperimental/Robyn

Error in check_hyper_limits

Open
#1,261 0 comments 0 reactions 1 assignee Claimed by @alxlyj View on GitHub
Dominant language
Jupyter Notebook
Stars
1.5k
Forks
433
PR merge metrics
No merged PRs in 30d

Description

We got a error during robyn_refresh step using a JSON output from previous model train.

```
Error in check_hyper_limits(hyperparameters_ordered, "scales"): xxx_scales's hyperparameter must have upper bound <=1
```

We do have the xxx_scales in the original model training set up with upper bound <=1, and I double checked that both xxx_scales bounds in InputCollect-hyperparameters and ExportedModel-hyper_updated are captured correctly in the json file. The only issue I can think of is that when we trained the model, the order of all hyperparameters are different than the order from this step though hyper_names(adstock = InputCollect$adstock, all_media = InputCollect$all_media) as we manually updated some, so the orders of InputCollect-hyperparameters, ExportedModel-hyper_values and ExportedModel-hyper_updated are all different.

Robyn Environment: both training and refresh were using Robyn [v3.11.1]

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.