facebook / facebook/zstd

Build error after PR #3665

Open
#4,303 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C
Stars
27.9k
Forks
2.6k
Avg merge
1d 3h
Merged PRs (30d)
8

Description

PR https://github.com/facebook/zstd/pull/3665 introduces a build error for me. I recently saw the release 1.5.7 improved performance and I wanted to check this out. Updating my submodule resulted in the error:
```
/usr/bin/ccache ... -O3 -o ext/zstd/build/cmake/lib/CMakeFiles/libzstd_static.dir/__/__/__/lib/decompress/huf_decompress_amd64.S.o -c ext/zstd/lib/decompress/huf_decompress_amd64.S
/usr/bin/ccache: invalid option -- 'D'
```

I bisected it to the aforementioned PR 3665.

The zstd project builds again by removing the if statement introduced in the PR. I don't have Xcode so I can't make a change that solves my Ubuntu ccache build issue as well as building on Xcode.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.