facebook / facebook/zstd

Buck build failed

Open
#3,643 0 comments 1 reaction 0 assignees View on GitHub
build
Dominant language
C
Stars
27.9k
Forks
2.6k
Avg merge
1d 3h
Merged PRs (30d)
8

Description

**Describe the bug**

`buck build programs:zstd` results in

```
Buck wasn't able to parse zstd/lib/BUCK:
Syntax error on line 136, column 5:
srcs=['common/error_private.c'],
^

This error happened while trying to get dependency '//lib:mem' of target '//programs:zstd'
```

**To Reproduce**

Run `buck build programs:zstd` in the root dir.

**Expected behavior**

It should build.

**Screenshots and charts**

**Additional context**

The bug is clearly due to a missing comma before `srcs=`, which is introduced in v1.5.0.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.