Question about dictionary reload conditions
Open
- Dominant language
- C
- Stars
- 27.9k
- Forks
- 2.6k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 8
Description
The dictionary reload conditions are:
https://github.com/facebook/zstd/blob/9b4833df2de3ab1779474c08725e398ea96127a1/lib/compress/zstd_compress.c#L5012-L5020
Should `cdict->compressionLevel == 0` be `cdict->compressionLevel != 0`?
If a dictionary is from `ZSTD_CCtx_loadDictionary()`, `cdict->compressionLevel` is 0.
If a dictionary is from `ZSTD_CCtx_refCDict()`, `cdict->compressionLevel` is not 0.
Contributor guide
Assessment
This issue has not been assessed yet.