Refactor ZSTD_estimateCCtxSize_usingCCtxParams_internal()
Open
enhancement
good first issue
long-term
- Dominant language
- C
- Stars
- 27.9k
- Forks
- 2.6k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 8
Description
`ZSTD_estimateCCtxSize_usingCCtxParams_internal()` currently takes a long list of parameters. Some (all?) of the parameters are extracted from external `ZSTD_CCtx_params` objects and passed in one by one. It would be cleaner to reduce the number of parameters by directly passing in a `ZSTD_CCtx_params const*`.
This should be an easy refactor. Code pointer: https://github.com/facebook/zstd/blob/90597d78eadadae7acf3633ab4d81ef7c4e6057f/lib/compress/zstd_compress.c#L1488-L1495
Contributor guide
Assessment
This issue has not been assessed yet.