facebook / facebook/zstd

Inclusion of Bazel build files in official zstd library

Open
#3,123 13 comments 3 reactions 0 assignees View on GitHub
build feature request help wanted
Dominant language
C
Stars
27.9k
Forks
2.6k
Avg merge
1d 3h
Merged PRs (30d)
8

Description

**Is your feature request related to a problem? Please describe.**
I need to use this library to build RocksDB. We use bazel to build everything, which means zstd must build with bazel.

Currently we are achieving bazel builds by pulling in https://github.com/cschuet/zstd/pull/2, which tends to go stale.

**Describe the solution you'd like**
Add a BUILD.bazel and WORKSPACE file to the zstd repo. Bazel users can use this and help maintain it.

**Describe alternatives you've considered**
1. Out-of-repository bazel projects like https://github.com/cschuet/zstd/pull/2
2. Using CMake (or whatever zstd uses) within bazel.

I know only a casual amount about the C++ build ecosystem, so I'm not sure what all the options are. Bazel is nice because users can issue a uniform set of commands across all languages, so I don't /have/ to know the C++ ecosystem to build C++ tools

**Additional context**
Would the authors accept a pull request with BUILD.bazel and WORKSPACE files?

See https://github.com/cschuet/zstd/blob/02cedda8da27c2043166dec046599e13da4a68b6/bazel/third_party/zstd.BUILD for expected contents.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.