facebook / facebook/watchman

[benchmark] Request for call-path / fairness review (GLD.SerializerBenchmark)

Open
#1,352 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
13.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Hello,

I'm Leonid Ganeline. We maintain an open multi-language serializer benchmark:

https://github.com/leo-gan/GLD.SerializerBenchmark

Your library is included in the suite (language: javascript, harness name: `bser`).
Implementation we use:

https://github.com/leo-gan/GLD.SerializerBenchmark/blob/master/javascript/src/serializers/binary.js

We would value a short review of whether our measurement is fair and idiomatic:

1. Does our call pattern match how you recommend using the library in performance-sensitive code?
2. Should we change options, encoder/decoder reuse, types, or buffer handling?
3. Is there a better API (or a second entry point worth a separate row in the suite)?

Concrete notes or a small PR against that wrapper would help a lot. We are happy to credit you in the docs.

The repo also includes a short Serialization course (101–401). If something important about your design is easy to misstate, a pointer is welcome—we can update the docs ourselves.

Thank you for maintaining this library.

Best regards,
Leonid Ganeline

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.