facebook / facebook/watchman

`test_clock_sync` seems flaky

Open
#1,104 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
13.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

This is similar to [[watchman/issues/1100] `test_sinceRelativeRoot` seems flaky](https://github.com/facebook/watchman/issues/1100)

I'm trying to build from source, and I keep getting flaky results on https://github.com/facebook/watchman/blob/6b0361c3464efcb5b7db11937f0bd9f84c865914/watchman/integration/test_clock.py#L29

While debugging, I added some log lines, and it immediately stopped flaking ([Heisenbug](https://en.wikipedia.org/wiki/Heisenbug) flag!)

I haven't fully looked into the implementation to understand this 100%, but could it be that:

https://github.com/facebook/watchman/blob/6b0361c3464efcb5b7db11937f0bd9f84c865914/watchman/integration/test_clock.py#L21-L27

can flake if not enough time passes between the assignment to `clock1` and the `clock2`?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.