facebook / facebook/watchman

Docs nav offset

Open
#1,039 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
13.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Noticed a minor visual inconsistency that can sometimes be annoying when browsing around the docs (e.g. it blocks the table of contents on the left), since the docs do not display the Support Ukraine banner, there's a redundant 60px offset for the navbar. Same applies for the Support page.

I'm willing to PR this, but should we...
a) include the support banner for the default layout as well
b) make the `.fixedHeaderContainer` class's `top: 60px` style conditional and only apply it within home's `{% include nav.html %}`

Screenshot 2022-06-28 at 10 24 34
Screenshot 2022-06-28 at 10 24 15
Screenshot 2022-06-28 at 10 24 01

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.