facebook / facebook/wangle

Add Boost include dirs to CMakelist.txt

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
3.1k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Currently the root CMakelist.txt file's include dirs are:

include_directories(
${CMAKE_SOURCE_DIR}/..
${FOLLY_INCLUDE_DIR}
${INCLUDE_DIR}
)

This is missing the boost include dirs.

I think it should be:

include_directories(
${CMAKE_SOURCE_DIR}/..
${FOLLY_INCLUDE_DIR}
${Boost_INCLUDE_DIRS}
${INCLUDE_DIR}
)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.