facebook / facebook/wangle

Function with noexcept specifier throws exception causes program terminated

Open
#186 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
3.1k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

The following function in wangle acceptor could possibly throws an exception in `makeNewAsyncSocket`
https://github.com/facebook/wangle/blob/master/wangle/acceptor/Acceptor.cpp#L305

While I didn't find any catch phrase that could handle this exception, thus when create new async socket failed, the exception causes the whole program terminated.

My question is, is that normal or should I override this function to deal with exceptions on my case?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.