facebook / facebook/wangle

Build fails on Debian Buster: Acceptor.cpp.o SocketPeeker.h:25:67: error: expected class-name before ‘,’ token

Open
#183 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
3.1k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Build fails on Debian Buster due to the following error. Please help... thanks.

`[ 3%] Building CXX object CMakeFiles/wangle.dir/acceptor/Acceptor.cpp.o
In file included from /usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/PeekingAcceptorHandshakeHelper.h:20,
from /usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzAcceptorHandshakeHelper.h:23,
from /usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/Acceptor.h:20,
from /usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:17:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:25:67: error: expected class-name before ‘,’ token
class TransportPeeker : public folly::AsyncTransport::ReadCallback,
^
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:62:8: error: ‘void wangle::TransportPeeker::getReadBuffer(void**, size_t*)’ marked ‘override’, but does not override
void getReadBuffer(void** bufReturn, size_t* lenReturn) override {
^~~~~~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:68:8: error: ‘void wangle::TransportPeeker::readEOF()’ marked ‘override’, but does not override
void readEOF() noexcept override {
^~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:76:8: error: ‘void wangle::TransportPeeker::readErr(const folly::AsyncSocketException&)’ marked ‘override’, but does not override
void readErr(const folly::AsyncSocketException& ex) noexcept override {
^~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:85:8: error: ‘void wangle::TransportPeeker::readDataAvailable(size_t)’ marked ‘override’, but does not override
void readDataAvailable(size_t len) noexcept override {
^~~~~~~~~~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:98:8: error: ‘bool wangle::TransportPeeker::isBufferMovable()’ marked ‘override’, but does not override
bool isBufferMovable() noexcept override {
^~~~~~~~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h: In destructor ‘virtual wangle::TransportPeeker::~TransportPeeker()’:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:47:20: error: ‘class folly::AsyncTransport’ has no member named ‘getReadCallback’; did you mean ‘BufferCallback’?
if (transport_.getReadCallback() == this) {
^~~~~~~~~~~~~~~
BufferCallback
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:48:18: error: ‘class folly::AsyncTransport’ has no member named ‘setReadCB’
transport_.setReadCB(nullptr);
^~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h: In member function ‘void wangle::TransportPeeker::start()’:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:58:18: error: ‘class folly::AsyncTransport’ has no member named ‘setReadCB’
transport_.setReadCB(this);
^~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h: In member function ‘void wangle::TransportPeeker::readErr(const folly::AsyncSocketException&)’:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:79:16: error: ‘class folly::AsyncTransport’ has no member named ‘setReadCB’
transport_.setReadCB(nullptr);
^~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h: In member function ‘void wangle::TransportPeeker::readDataAvailable(size_t)’:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/SocketPeeker.h:92:18: error: ‘class folly::AsyncTransport’ has no member named ‘setReadCB’
transport_.setReadCB(nullptr);
^~~~~~~~~
In file included from /usr/local/mcrouter/pkgs/wangle/wangle/../wangle/ssl/SSLContextManager.h:27,
from /usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:32:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/ssl/SSLSessionCacheManager.h: At global scope:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/ssl/SSLSessionCacheManager.h:141:88: error: expected class-name before ‘{’ token
struct ContextSessionCallbacks : public folly::SSLContext::SessionLifecycleCallbacks {
^
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/ssl/SSLSessionCacheManager.h:142:10: error: ‘void wangle::SSLSessionCacheManager::ContextSessionCallbacks::onNewSession(SSL*, folly::ssl::SSLSessionUniquePtr)’ marked ‘override’, but does not override
void onNewSession(SSL* ssl, folly::ssl::SSLSessionUniquePtr sessionPtr) override;
^~~~~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp: In member function ‘std::shared_ptr wangle::Acceptor::recreateFizzContext()’:
/usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:150:14: error: ‘using element_type = class fizz::server::FizzServerContext’ {aka ‘class fizz::server::FizzServerContext’} has no member named ‘getFactoryPtr’; did you mean ‘getFactory’?
ctx->getFactoryPtr(),
^~~~~~~~~~~~~
getFactory
/usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp: In member function ‘void wangle::Acceptor::connectionReady(folly::AsyncTransport::UniquePtr, const folly::SocketAddress&, const string&, wangle::SecureTransportType, wangle::TransportInfo&)’:
/usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:337:28: error: ‘class folly::AsyncTransport’ has no member named ‘getUnderlyingTransport’; did you mean ‘AsyncTransport’?
auto asyncSocket = sock->getUnderlyingTransport();
^~~~~~~~~~~~~~~~~~~~~~
AsyncTransport
/usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:337:62: error: expected primary-expression before ‘>’ token
auto asyncSocket = sock->getUnderlyingTransport();
^
/usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:337:64: error: expected primary-expression before ‘)’ token
auto asyncSocket = sock->getUnderlyingTransport();
^
In file included from /usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:28:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h: In instantiation of ‘static std::unique_ptr<_Tp> wangle::FizzConfigUtil::createTicketCipher(const wangle::TLSTicketKeySeeds&, std::chrono::seconds, std::chrono::seconds, std::shared_ptr, std::shared_ptr, folly::Optional >) [with TicketCipherT = fizz::server::Aead128GCMTicketCipher >; std::chrono::seconds = std::chrono::duration]’:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h:84:30: required from here
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h:47:63: error: no matching function for call to ‘fizz::FizzUtil::createTicketCipher > >(const std::vector >&, const char [1], const std::vector >&, std::chrono::seconds&, std::chrono::seconds&, std::remove_reference&>::type, std::remove_reference&>::type, std::remove_reference >&>::type)’
return fizz::FizzUtil::createTicketCipher(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
seeds.oldSeeds,
~~~~~~~~~~~~~~~
"",
~~~
seeds.newSeeds,
~~~~~~~~~~~~~~~
validity,
~~~~~~~~~
handshakeValidity,
~~~~~~~~~~~~~~~~~~
std::move(factory),
~~~~~~~~~~~~~~~~~~~
std::move(certManager),
~~~~~~~~~~~~~~~~~~~~~~~
std::move(pskContext));
~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h:21,
from /usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:28:
/usr/local/include/fizz/util/FizzUtil.h:48:41: note: candidate: ‘template static std::unique_ptr<_Tp> fizz::FizzUtil::createTicketCipher(const std::vector >&, const string&, const std::vector >&, std::chrono::seconds, std::chrono::seconds, folly::Optional >)’
static std::unique_ptr createTicketCipher(
^~~~~~~~~~~~~~~~~~
/usr/local/include/fizz/util/FizzUtil.h:48:41: note: template argument deduction/substitution failed:
In file included from /usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:28:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h:47:63: note: candidate expects 6 arguments, 8 provided
return fizz::FizzUtil::createTicketCipher(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
seeds.oldSeeds,
~~~~~~~~~~~~~~~
"",
~~~
seeds.newSeeds,
~~~~~~~~~~~~~~~
validity,
~~~~~~~~~
handshakeValidity,
~~~~~~~~~~~~~~~~~~
std::move(factory),
~~~~~~~~~~~~~~~~~~~
std::move(certManager),
~~~~~~~~~~~~~~~~~~~~~~~
std::move(pskContext));
~~~~~~~~~~~~~~~~~~~~~~
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h:57:63: error: no matching function for call to ‘fizz::FizzUtil::createTicketCipher > >(const std::vector >&, const value_type&, const std::vector >&, std::chrono::seconds&, std::chrono::seconds&, std::remove_reference&>::type, std::remove_reference&>::type, std::remove_reference >&>::type)’
return fizz::FizzUtil::createTicketCipher(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
seeds.oldSeeds,
~~~~~~~~~~~~~~~
seeds.currentSeeds.at(0),
~~~~~~~~~~~~~~~~~~~~~~~~~
seeds.newSeeds,
~~~~~~~~~~~~~~~
validity,
~~~~~~~~~
handshakeValidity,
~~~~~~~~~~~~~~~~~~
std::move(factory),
~~~~~~~~~~~~~~~~~~~
std::move(certManager),
~~~~~~~~~~~~~~~~~~~~~~~
std::move(pskContext));
~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h:21,
from /usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:28:
/usr/local/include/fizz/util/FizzUtil.h:48:41: note: candidate: ‘template static std::unique_ptr<_Tp> fizz::FizzUtil::createTicketCipher(const std::vector >&, const string&, const std::vector >&, std::chrono::seconds, std::chrono::seconds, folly::Optional >)’
static std::unique_ptr createTicketCipher(
^~~~~~~~~~~~~~~~~~
/usr/local/include/fizz/util/FizzUtil.h:48:41: note: template argument deduction/substitution failed:
In file included from /usr/local/mcrouter/pkgs/wangle/wangle/acceptor/Acceptor.cpp:28:
/usr/local/mcrouter/pkgs/wangle/wangle/../wangle/acceptor/FizzConfigUtil.h:57:63: note: candidate expects 6 arguments, 8 provided
return fizz::FizzUtil::createTicketCipher(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
seeds.oldSeeds,
~~~~~~~~~~~~~~~
seeds.currentSeeds.at(0),
~~~~~~~~~~~~~~~~~~~~~~~~~
seeds.newSeeds,
~~~~~~~~~~~~~~~
validity,
~~~~~~~~~
handshakeValidity,
~~~~~~~~~~~~~~~~~~
std::move(factory),
~~~~~~~~~~~~~~~~~~~
std::move(certManager),
~~~~~~~~~~~~~~~~~~~~~~~
std::move(pskContext));
~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [CMakeFiles/wangle.dir/build.make:63: CMakeFiles/wangle.dir/acceptor/Acceptor.cpp.o] Error 1
make[3]: Leaving directory '/usr/local/mcrouter/pkgs/wangle/wangle'
make[2]: *** [CMakeFiles/Makefile2:73: CMakeFiles/wangle.dir/all] Error 2
make[2]: Leaving directory '/usr/local/mcrouter/pkgs/wangle/wangle'
make[1]: *** [Makefile:152: all] Error 2
make[1]: Leaving directory '/usr/local/mcrouter/pkgs/wangle/wangle'
make: *** [Makefile_ubuntu-18.04:23: .wangle-done] Error 2`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.