facebook / facebook/stylex

[fix] Better media query sorting

Open
#1,407 0 comments 5 reactions 1 assignee Claimed by @abhakat View on GitHub
Dominant language
JavaScript
Stars
10.3k
Forks
481
Avg merge
3d 8h
Merged PRs (30d)
13

Description

Right now we sort media queries by alphanumeric order, leading to unexpected media query ordering and behaviour for overlapping breakpoints. The config `enableMediaQueryOrder` exists to tackle this properly but it has some unresolved bugs and does not yet work with `defineConsts`. We can improve media query ordering by sorting queries in a way that smaller breakpoints (covering less range) win over larger ones.

For example, as a starting point:
- For max-width, sort from smallest number to largest
- For min-width, the inverse

Steps:
- Modify block here https://github.com/facebook/stylex/blob/main/packages/%40stylexjs/babel-plugin/src/index.js#L459-L482
- Look for @media rules and sort as above

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.