facebook / facebook/stylex

[eslint-plugin] eslint plugin doesn't specify eslint version compat

Open
#1,248 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10.3k
Forks
481
Avg merge
3d 8h
Merged PRs (30d)
13

Description

Current 0.16.0 doesn't specify eslint as a peer dep, so we have no idea with which version of eslint this plugin is compatible with https://github.com/facebook/stylex/blob/f3b4e4485161d9d6a58ce43ca973a113b830ff97/packages/%40stylexjs/eslint-plugin/package.json#L18-L22

Could this be added?

I was trying to make a plugin for RSD (ref https://github.com/facebook/react-strict-dom/discussions/304#discussioncomment-14499833) and wanted to reused this plugin to avoid redoing the same work, and I tried latest eslint v9 but it seems it's not compatible because I got something like this

```
Oops! Something went wrong! :(

ESLint: 9.36.0

Error: ESLint context does not provide source code access. Please update ESLint to v>=8.40.0. See: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
```

Would be nice to know for sure :)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.