facebook / facebook/stylex

[eslint-plugin] Split up `valid-styles`

Open
#1,201 2 comments 3 reactions 1 assignee Claimed by @jcperez-ch View on GitHub
Dominant language
JavaScript
Stars
10.3k
Forks
481
Avg merge
3d 8h
Merged PRs (30d)
13

Description

Constant ask from ESLint folks. Most common complaint with linting is that valid-styles as a rule is not descriptive and difficult to understand. It handles a lot of things: property validation, type checking, object structure validation, pseudo-selectors and at-rules, border shorthand expansion, and converts nonstandard properties to current ones.

There's also some duplication with `valid-shorthands`.

Let's consolidate and split up logic where it makes sense. There are some ESLint perf regressions from scanning styles multiple times so let's think through what makes sense

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.