Multireadrandom in benchmark.sh doesn't use batched MultiGet
Open
enhancement
- Dominant language
- C++
- Stars
- 32.1k
- Forks
- 6.9k
- Avg merge
- 32m
- Merged PRs (30d)
- 1
Description
https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/tools/db_bench_tool.cc#L1548
https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/tools/benchmark.sh#L521
https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/include/rocksdb/db.h#L586
https://github.com/facebook/rocksdb/wiki/Performance-Benchmarks#test-3-multi-random-read-benchmarksh-multireadrandom
Fortunately, regression_test.sh does use batched MultiGet:
https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/tools/regression_test.sh#L249
Contributor guide
Assessment
This issue has not been assessed yet.