fifo compaction ttl not working
Open
design discussion
- Dominant language
- C++
- Stars
- 32.1k
- Forks
- 6.9k
- Avg merge
- 32m
- Merged PRs (30d)
- 1
Description
@jamesgolick @sagar0
fifo compaction ttl not working when there is a file that is ingested by SSTFileWriter because of the following code in fifo compaction picker
because the loop breaks out when creation time is 0 and the creation time of sst files created by "ingesting external sst files" is 0. The SST Writer does not give any creation time.
I think this is a bug here. Either remove this condition here or add creation time on SST file writer when constructing the file. But I am not very sure if there is any other specific purpose of this 'creation_time==0' condition here. Can I remove this?
Contributor guide
Assessment
This issue has not been assessed yet.