facebook / facebook/rocksdb

Problems about FileSystem and Env/SpecialEnv

Open
#9,274 2 comments 0 reactions 0 assignees View on GitHub
question up-for-grabs
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

The Env interfaces and file system interfaces have been separated after v6.6? And I am encountering some problems when trying to add a new file system.

First, we have SpecialEnv which inherits EnvWrapper, but EnvWrapper doesn't provide constructor with env's file system and the default constructor will initial a file system called LegacyFileSystemWrapper, the LegacyFileSystemWrapper will just call env(and its function) to operate file. So I made this pr https://github.com/facebook/rocksdb/pull/9267

Second, in db_wal_test.cc EnrichedSpecialEnv implements its DeleteFile, the function will be called by LegacyFileSystemWrapper (because LegacyFileSystemWrapper just call env's function) so that it will fail when you want to call you own filesystem.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.