facebook / facebook/rocksdb

Building for Win7 attempts to use a struct definition and enum value not defined until Win8

Open
#9,016 2 comments 0 reactions 0 assignees View on GitHub
Build up-for-grabs
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

In the `WinFileSystem::AreFilesSame` function, the `GetFileInformationByHandleEx` Win32 API is invoked. It requests the `FileIdInfo` enum value and passes a pointer to a `FILE_ID_INFO` struct. These are not defined in WinBase.h if `_WIN32_WINNT < _WIN32_WINNT_WIN8` so I think the `#ifdef` at the top of this function should be changed to that.
https://github.com/facebook/rocksdb/blob/ee239df351f486a23793e637125965a3c0c3987f/port/win/env_win.cc#L918

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.