facebook / facebook/rocksdb

Use ReadTier::kMemtableTier in read-before-write for max_successive_merges

Open
#8,516 3 comments 1 reaction 0 assignees View on GitHub
design discussion
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

Currently, `max_successive_merges` performs a read-before-write from disk to replace the current merge value in the memtable with a `put`. That read is blocking, which stalls the current thread. It would be better if `max_successive_merges` performed the read only within the memtable tier, replacing the current set of merge operands with the result of partially merging them. This likely requires introducing a new `ValueType`, and maybe a new toggle.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.