Use CMAKE_CXX_COMPILER_LAUNCHER instead of RULE_LAUNCH_COMPILE
- Dominant language
- C++
- Stars
- 32.1k
- Forks
- 6.9k
- Avg merge
- 32m
- Merged PRs (30d)
- 1
Description
https://github.com/facebook/rocksdb/blob/25d54c799ce5fb6887a151f4f584bf8d84c1256e/CMakeLists.txt#L60-L61
This should be replaced with the new way of using `CMAKE_CXX_COMPILER_LAUNCHER` var instead of global property.
https://cmake.org/cmake/help/v3.19/variable/CMAKE_LANG_COMPILER_LAUNCHER.html
When combined with `set(... CACHE ...)` or `option()`, it will allows user overwrite when ccache is not wanted on system with ccache installed, or when multiple ccache are available but the found one is incorrect.
This feature is available since CMake 3.4, within https://github.com/facebook/rocksdb/blob/25d54c799ce5fb6887a151f4f584bf8d84c1256e/CMakeLists.txt#L35 , so it should be safe to switch.
Similar issue also reported here:
https://github.com/Tencent/rapidjson/issues/1794
Contributor guide
Assessment
This issue has not been assessed yet.