facebook / facebook/rocksdb

The Relationship between ImmutableCFOptions , MutableCFOptions, and ColumnFamilyOptions should be cleaned up

Open
#7,602 0 comments 1 reaction 0 assignees View on GitHub
up-for-grabs
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

As the code is currently written, you can create ImmutableCFOptions and MutableCFOptions from a ColumnFamilyOptions but the inverse is not true. This limitation is at least partially true because the ImmutableCFOptions uses "raw pointers" in it instead of the "shared" pointer.

I think an ImmutableCFOptions may also contain some of the options from DBOptions, and that should probably also be cleaned up.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.