facebook / facebook/rocksdb

[BUG] ImportCF will violate wal's continuation

Open
#6,813 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

https://github.com/facebook/rocksdb/blob/c21c459771f65e8e9eae2dc8ee840fc9172996ff/db/import_column_family_job.cc#L163

TransactionLogIterator iteration will stop on the first dis-continuation batch as a Corruption

However, this place will make current rocksdb instance wal sequence dis-continuous, at this situation,
if TransactionLogIterator is created immediately after a cf imported, the iteration will fail.

It's easy to reproduce by an unittest.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.