facebook / facebook/rocksdb

Skew between DBOptions and ImmutableDBOptions

Open
#6,677 0 comments 0 reactions 1 assignee Claimed by @anand1976 View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

Prior to #6552 , the ImmutableDBOptions and DBOptions had a one-to-one value correspondence. Every value that was in ImmutableDBOptions was also in DBOptions.

To simplify the API, the std::shared_ptr fs value was deleted from the DBOptions but it was not removed from ImmutableDBOptions.

This means that there is now a divergence between these two structures.

Since #6552, you also cannot create an ImmutableDBOptions with a DBOptions that has a NULL env (it will SEGV). All DBOptions must be sanitized prior to making them Immutable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.