facebook / facebook/rocksdb

IPv6 paths not correctly parsed in hdfs connectToPath

Open
#6,462 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

> Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

### Expected behavior
hdfs://[2a05::]:port/ should work

### Actual behavior
"Bad uri for hdfs"

### Steps to reproduce the behavior
Look at the source code in rocksdb/hdfs/env_hdfs.h, it does a naive split. Does not parse IPv6 addresses correctly.

~~~
std::vector parts;
split(hostport, ':', parts);
if (parts.size() != 2) {
throw HdfsFatalException("Bad uri for hdfs " + uri);
~~~

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.