facebook / facebook/rocksdb

The OptimizeForXXX methods in FileSystem and Env use ImmutableDBOptions, a non-public struct

Open
#6,361 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

There are a set of methods EnvOptions OptimizeForXXX in the Env and FileSystem classes that take in
EnvOptions and ImmutableDBOptions parameters. Unfortunately, the ImmutableDBOptions is not part of the public API for RocksDB (it is defined in the options/db_options.h header).

For consistency, either the ImmutableDBOptions needs to be defined in a public (rocksdb/include) header file, or these methods should instead take a DBOptions object.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.