facebook / facebook/rocksdb

Unclear how to clean up from interrupted CreateCheckpoint

Open
#6,235 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

Related: #6015, #6233

### Expected behavior

CreateCheckpoint creates a clone db in a specified directory. You'd expect any of these to clean up from an interrupted CreateCheckpoint:
a) rm -rf the specified directory
b) DestroyDB the specified directory
And maybe
c) Do another CreateCheckpoint on the same directory

### Actual behavior

(a) and (b) don't work, because until completed, the db is in a tmp directory. (c) does work, but that's not intuitive or friendly because although CreateCheckpoint will clean up the tmp directory, it will fail if the specified db directory itself does exist. Good for atomicity, bad for clear deletion semantics.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.